Always increase timeout for packaging tests #48945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach did not work because the system property is passed to Gradle but not to the tests JVM. We shouldn't really pass this to the tests as we wouldn't want to have differences. This timeout being different might not be bad, but having a way to differentiate could lead to others and it's best avoided.
alpar-t
added
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Contributor
Author
|
@mark-vieira I'm going to merge this to be able to test these jobs. Will act on any feedback on a new PR. |
alpar-t
added a commit
that referenced
this pull request
Nov 12, 2019
The previous approach did not work because the system property is passed to Gradle but not to the tests JVM. We shouldn't really pass this to the tests as we wouldn't want to have differences. This timeout being different might not be bad, but having a way to differentiate could lead to others and it's best avoided.
alpar-t
added a commit
that referenced
this pull request
Nov 12, 2019
The previous approach did not work because the system property is passed to Gradle but not to the tests JVM. We shouldn't really pass this to the tests as we wouldn't want to have differences. This timeout being different might not be bad, but having a way to differentiate could lead to others and it's best avoided.
Contributor
|
I'm good with using the more lenient timeouts across the board. They are by no means unreasonable time limits and I think the less conditional logic we have wrt test environment the better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach did not work because the system property is passed
to Gradle but not to the tests JVM.
We shouldn't really pass this to the tests as we wouldn't want to have
differences.
This timeout being different might not be bad, but having a way to
differentiate could lead to others and it's best avoided.