Create a thread dump if ES fails to start in packaging tests #48932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to elastic#15385. Hoping to get some insight on CI failures.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@mark-vieira I'm going to merge this to be able to test these jobs. Will act on any feedback on a new PR. |
alpar-t
added a commit
that referenced
this pull request
Nov 12, 2019
Relates to #15385. Hoping to get some insight on CI failures.
alpar-t
added a commit
that referenced
this pull request
Nov 12, 2019
Relates to #15385. Hoping to get some insight on CI failures.
mark-vieira
reviewed
Nov 12, 2019
| rm(installation.config("elasticsearch.keystore")); | ||
|
|
||
| Archives.runElasticsearch(installation, sh); | ||
| try { |
Contributor
There was a problem hiding this comment.
Would it make sense to just bake this into waitForElasticsearch()?
Contributor
Author
There was a problem hiding this comment.
The pid file will not always be at the same location. We could but it would take significantly more work to make sure we always track the pid file in the installation so we can reliably reference it
Contributor
There was a problem hiding this comment.
That's fine. If we expect this to be mostly temporary, or only really helpful for this test, then let's press on as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #15385.
Hoping to get some insight on CI failures.