[#40366] Silence some lint warnings in server project #48927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
alpar-t
approved these changes
Nov 11, 2019
Contributor
alpar-t
left a comment
alpar-t
left a comment
There was a problem hiding this comment.
LGTM. I haven't looked into if/how some of the @SuppressWarnings could be further addressed, I consider this an improvement regardless as it greatly reduces the scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #40366. Silence a number of lint warnings in the
:serverproject, which arise when re-enabling suppressed warnings inserver/build.gradle. Eventually I will remove the compiler flags that suppress these warnings, but first I'll need to apply a number of PRs to fix or silence the warnings themselves.