Remove support for sparse vectors. #48781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>breaking
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
jtibshirani
force-pushed
the
remove-sparse-vector
branch
3 times, most recently
from
630e4e3 to
3e83ba5
Compare
jtibshirani
force-pushed
the
remove-sparse-vector
branch
2 times, most recently
from
a300dcb to
7e30732
Compare
jtibshirani
force-pushed
the
remove-sparse-vector
branch
from
7e30732 to
e8fd8a1
Compare
jtibshirani
force-pushed
the
remove-sparse-vector
branch
from
e8fd8a1 to
0242a5e
Compare
Contributor
Author
|
@mayya-sharipova this is now ready for a review (after some initial issues with test failures). |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
mayya-sharipova
approved these changes
Nov 13, 2019
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@jtibshirani Thanks Julie, very nice approach for the bwc to keep just a definition of the type.
| * @deprecated The sparse_vector type was deprecated in 7.x and removed in 8.0. This mapper | ||
| * definition only exists so that 7.x indices can be read without error. | ||
| */ | ||
| @Deprecated |
Contributor
There was a problem hiding this comment.
may be add TODO: to remove this class in 9.0
| assertThat(e.getCause(), instanceOf(IllegalArgumentException.class)); | ||
| assertThat(e.getCause().getMessage(), containsString( | ||
| "dimension number must be a non-negative integer value not exceeding [65535], got [-50]")); | ||
| public void testSparseVectorWith7xIndex() throws Exception { |
Contributor
There was a problem hiding this comment.
Nicely written test!
jtibshirani
added
:Search Relevance/Vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #48368. This PR removes support for
sparse_vectoron newindices. On 7.x indices a
sparse_vectorcan still be defined, but it is notpossible to index or search on it.