Remove unnecessary details logged for OIDC #48746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unnecessary details logged for OIDC.
- truncate the string keeping first and last 2 chars. - the `OIDCTokenResponse` did not parse the error scenario correctly. - checks for the response status and then on error prints the response message as warning
…ecurity/authc/oidc/OpenIdConnectAuthenticator.java Co-Authored-By: Ioannis Kakavas <[email protected]>
… 400 as indicated by the standard
jkakavas
added
>bug
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security (:Security/Authentication) |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
1 similar comment
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticmachine update branch |
tvernum
approved these changes
Nov 13, 2019
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Nov 13, 2019
This commit removes unnecessary details logged for OIDC. Co-Authored-By: Ioannis Kakavas <[email protected]>
jkakavas
added a commit
that referenced
this pull request
Nov 13, 2019
This commit removes unnecessary details logged for OIDC. Co-Authored-By: Ioannis Kakavas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes unnecessary details logged for OIDC.
Supersedes: #48271