[DOCS] Reformat decimal digit token filter #48722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
>docs
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-search (:Search/Analysis) |
82 tasks
romseygeek
approved these changes
Nov 1, 2019
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. It's odd that this is a tokenfilter rather than a charfilter, but that's a matter for lucene rather than a docs issue :)
It might be useful to add a token to the analysis example that mixes bengali numbers and text, to illustrate that the filter operates on characters and not just whole tokens.
Contributor
Author
|
Thanks @romseygeek. Good point re: mixing numbers and text. I'll update the analysis example accordingly. |
jrodewig
added a commit
that referenced
this pull request
Nov 1, 2019
jrodewig
added a commit
that referenced
this pull request
Nov 1, 2019
jrodewig
added a commit
that referenced
this pull request
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformats the decimal digit token filter docs as part of #44726.
Changes