Skip to content

Do not ignore exception when trim unreferenced readers #48470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Do not ignore exception when trim unreferenced readers #48470

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86c6f32
Do not ignore exception when trim unreferenced readers
dnhatn Oct 24, 2019
ba7f7a2
keep original exception
dnhatn Oct 25, 2019
acbac3a
Merge branch 'master' into trim-translog-reader
dnhatn Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions server/src/main/java/org/elasticsearch/index/translog/Translog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,15 +1691,13 @@ public void trimUnreferencedReaders() throws IOException {
break;
}
iterator.remove();
IOUtils.closeWhileHandlingException(reader);
final Path translogPath = reader.path();
logger.trace("delete translog file [{}], not referenced and not current anymore", translogPath);
logger.trace("delete translog file [{}], not referenced and not current anymore", reader.path);
// The checkpoint is used when opening the translog to know which files should be recovered from.
// We now update the checkpoint to ignore the file we are going to remove.
// Note that there is a provision in recoverFromFiles to allow for the case where we synced the checkpoint
// but crashed before we could delete the file.
// sync at once to make sure that there's at most one unreferenced generation.
current.sync();
IOUtils.close(reader, current::sync);
deleteReaderFiles(reader);
}
assert readers.isEmpty() == false || current.generation == minReferencedGen :
Expand Down