Refine the auto-formatting settings #48446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split arguments for methods, constructors etc into separate lines when they wrap * Enable "joined wrapped lines", which basically means the formatter will ignore existing line breaks and join and re-wrap statements. I had originally hesitated about enabling this, but without it the codebase's style won't be as consistent as it should be, defeating the point of all this formatting business. * Disable formatting between `// tag::` and `// end::` comments, which are the code snippet markers for the docs. They need a different line length, which isn't possible to configure separately. * Detect and preserve aligned line comments at the end of consecutive lines. * And a bunch of other tweaks. Also update the contribution guidelines.
pugnascotia
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Oct 29, 2019
* Split arguments for methods, constructors etc into separate lines when they wrap * Enable "joined wrapped lines", which basically means the formatter will ignore existing line breaks and join and re-wrap statements. I had originally hesitated about enabling this, but without it the codebase's style won't be as consistent as it should be, defeating the point of all this formatting business. * Disable formatting between `// tag::` and `// end::` comments, which are the code snippet markers for the docs. They need a different line length, which isn't possible to configure separately. * Detect and preserve aligned line comments at the end of consecutive lines. * And a bunch of other tweaks. Also update the contribution guidelines.
pugnascotia
added a commit
that referenced
this pull request
Oct 29, 2019
Backport of #48446. Update the Eclipse formatter settings as follows: * Split arguments for methods, constructors etc into separate lines when they wrap * Enable "joined wrapped lines", which basically means the formatter will ignore existing line breaks and join and re-wrap statements. I had originally hesitated about enabling this, but without it the codebase's style won't be as consistent as it should be, defeating the point of all this formatting business. * Disable formatting between `// tag::` and `// end::` comments, which are the code snippet markers for the docs. They need a different line length, which isn't possible to configure separately. * Detect and preserve aligned line comments at the end of consecutive lines. * And a bunch of other tweaks. Also update the contribution guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Eclipse formatter settings as follows:
they wrap
will ignore existing line breaks and join and re-wrap statements. I
had originally hesitated about enabling this, but without it the
codebase's style won't be as consistent as it should be, defeating the
point of all this formatting business.
// tag::and// end::comments, whichare the code snippet markers for the docs. They need a different line
length, which isn't possible to configure separately.
lines.
Also update the contribution guidelines.