Ensure SLM stats does not block an in-place upgrade from 7.4 #48367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7.5+ for SLM requires [stats] object to exist in the cluster state. When doing an in-place upgrade from 7.4 to 7.5+ [stats] does not exist in cluster state, result in an exception on startup [1]. This commit moves the [stats] to be an optional object in the parser and if not found will default to an empty stats object. [1] Caused by: java.lang.IllegalArgumentException: Required [stats]
jakelandis
added
>bug
blocker
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
gwbrown
approved these changes
Oct 22, 2019
Contributor
gwbrown
left a comment
gwbrown
left a comment
There was a problem hiding this comment.
LGTM once CI is happy, thanks again for taking care of this. We'll likely want to expand on the restart test at some point, but that can be done in another PR.
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Author
|
@elasticmachine update branch |
dakrone
approved these changes
Oct 23, 2019
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this Jake!
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 23, 2019
…#48367) 7.5+ for SLM requires [stats] object to exist in the cluster state. When doing an in-place upgrade from 7.4 to 7.5+ [stats] does not exist in cluster state, result in an exception on startup [1]. This commit moves the [stats] to be an optional object in the parser and if not found will default to an empty stats object. [1] Caused by: java.lang.IllegalArgumentException: Required [stats] Co-authored-by: Elastic Machine <[email protected]>
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 23, 2019
…#48367) 7.5+ for SLM requires [stats] object to exist in the cluster state. When doing an in-place upgrade from 7.4 to 7.5+ [stats] does not exist in cluster state, result in an exception on startup [1]. This commit moves the [stats] to be an optional object in the parser and if not found will default to an empty stats object. [1] Caused by: java.lang.IllegalArgumentException: Required [stats] Co-authored-by: Elastic Machine <[email protected]>
Contributor
Author
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5+ for SLM requires [stats] object to exist in the cluster state.
When doing an in-place upgrade from 7.4 to 7.5+ [stats] does not exist
in cluster state, result in an exception on startup [1].
This commit moves the [stats] to be an optional object in the parser
and if not found will default to an empty stats object.
[1] Caused by: java.lang.IllegalArgumentException: Required [stats]
Note - this is was not caught by normal full cluster state restart tests since by default there is no SLM data in cluster state.
Below is the full error when the test is run without the fix: