Skip to content

Reindex resilience against red shard test #48342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Reindex resilience against red shard test #48342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6efc422
Reindex resilience against red shard test
henningandersen Oct 22, 2019
379548f
Merge remote-tracking branch 'origin/reindex_v2' into test_reindex_re…
henningandersen Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions modules/reindex/src/test/java/org/elasticsearch/index/reindex/ReindexResilientSearchIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ public void testDataNodeRestart() throws Exception {
.mapToObj(i -> client().prepareIndex("test", "doc", String.valueOf(i)).setSource("data", i)).collect(Collectors.toList()));

ensureGreen("test");
String reindexNode = internalCluster().startCoordinatingOnlyNode(Settings.EMPTY);
NodeClient reindexNodeClient = internalCluster().getInstance(NodeClient.class, reindexNode);

ReindexRequest reindexRequest = new ReindexRequest();
reindexRequest.setSourceIndices("test").setSourceBatchSize(1);
Expand All @@ -106,12 +104,12 @@ public void testDataNodeRestart() throws Exception {

TaskId taskId = new TaskId(response.getTaskId());

Set<String> names = Arrays.stream(internalCluster().getNodeNames())
Set<String> reindexNodeNames = Arrays.stream(internalCluster().getNodeNames())
.map(name -> Tuple.tuple(internalCluster().getInstance(NodeClient.class, name).getLocalNodeId(), name))
.filter(idAndName -> taskId.getNodeId().equals(idAndName.v1())).map(Tuple::v2).collect(Collectors.toSet());

assertEquals(1, names.size());
String notToRestart = names.iterator().next();
assertEquals(1, reindexNodeNames.size());
String notToRestart = reindexNodeNames.iterator().next();

internalCluster().getInstances(NodeClient.class);
assertBusy(() -> {
Expand All @@ -123,19 +121,21 @@ public void testDataNodeRestart() throws Exception {
assertThat(client().admin().cluster().prepareListTasks().setActions(SearchAction.NAME).get().getTasks(), Matchers.empty());
}, 30, TimeUnit.SECONDS);

Set<String> restartableNodes = internalCluster().nodesInclude("test")
.stream().filter(id -> id.equals(notToRestart) == false).collect(Collectors.toSet());
for (int i = 0; i < randomIntBetween(1,5); ++i) {
// todo: replace following two lines with below once search fails on RED every time.
String nodeToRestart = randomFrom(internalCluster().nodesInclude("test")
.stream().filter(id -> id.equals(notToRestart) == false).collect(Collectors.toSet()));
internalCluster().restartNode(nodeToRestart, new InternalTestCluster.RestartCallback());
ensureGreen();
// internalCluster().restartRandomDataNode(new InternalTestCluster.RestartCallback() {
// @Override
// public Settings onNodeStopped(String nodeName) throws Exception {
// internalCluster().restartRandomDataNode();
// return super.onNodeStopped(nodeName);
// }
// });
String node1ToRestart = randomFrom(restartableNodes);
internalCluster().restartNode(node1ToRestart, new InternalTestCluster.RestartCallback() {
@Override
public Settings onNodeStopped(String nodeName) throws Exception {
if (restartableNodes.size() > 1) {
String node2ToRestart = randomValueOtherThan(node1ToRestart, () -> randomFrom(restartableNodes));
logger.info("--> restarting second node: " + node2ToRestart);
internalCluster().restartNode(node2ToRestart, new InternalTestCluster.RestartCallback());
}
return super.onNodeStopped(nodeName);
}
});
}

rethrottle().setTaskId(taskId)
Expand Down