Download jdk to a temp file to make sure retries work #48249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that retries will not work if the conncetion is refused. The version of curl in the base image does not support `--retry-connrefused`
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
approved these changes
Oct 18, 2019
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM.
| ENV JAVA_HOME /opt/jdk-${jdkVersion} | ||
|
|
||
| RUN curl -L --retry 8 -s ${jdkUrl} | tar -C /opt -zxf - | ||
| RUN curl -L --retry 8 -s ${jdkUrl} --continue-at - --output /tmp/jdk.tar.gz && \ |
Contributor
There was a problem hiding this comment.
I think it might be worthwhile to use -S here so we can see the errors. Is there significant motivation for suppressing all output here? AFAIK this doesn't affect the image in any way.
pugnascotia
approved these changes
Oct 21, 2019
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Contributor
Author
|
@elasticmachine update branch |
Contributor
|
@atorok added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that retries will not work if the connection is refused.
The version of curl in the base image does not support
--retry-connrefusedCloses #48129