Skip to content

Conversation

@benwtrent
Copy link
Member

This is a port of #48075 .

This is required for the persist model code to work in master and then be backported to 7.x

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


public class LogisticRegressionTests extends AbstractXContentTestCase<LogisticRegression> {

LogisticRegression createTestInstance(int numberOfWeights) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static?

@benwtrent
Copy link
Member Author

Jenkins test this

@benwtrent benwtrent merged commit e2b66ed into elastic:master Oct 18, 2019
@benwtrent benwtrent deleted the feature/ml-inference-add-logistic-regression-aggregator branch October 18, 2019 13:21
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants