-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove type parameters from Client.prepareDelete() and Client.prepareUpdate() #48185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove type parameters from Client.prepareDelete() and Client.prepareUpdate() #48185
Conversation
…ction' into types-removal/bulk-request-action
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
|
@elasticmachine run elasticsearch-ci/packaging-sample |
|
@elasticmachine update branch |
|
@romseygeek to check I understand the change -- in addition to removing typed versions of |
|
I had intended to remove prepareIndex(index, type) in a separate PR but rebased against the wrong branch apparently. I can separate the two changes out if that makes it easier to review? |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
If it's not a ton of work, I think that would be cleanest. But if it will take significant time, we could just update the PR description to clearly list out what has changed, and mention the plan for a follow-up PR? |
|
@romseygeek and I discussed offline -- we will keep the change as-is because would be a large amount of work to separate it out. |
jtibshirani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
|
@elasticmachine update branch |
Type parameters are no longer used in DeleteRequest or UpdateRequest; this commit
removes them from the
prepareXmethods onClient, as well as removingsetType()and deprecated constructors on
XRequestBuilderobjects.Relates to #41059