Fix ILM HLRC Javadoc->Documentation links #48083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
hub-cap
approved these changes
Oct 15, 2019
Contributor
hub-cap
left a comment
hub-cap
left a comment
There was a problem hiding this comment.
LGTM but the javadoc URLs are broken on 2 lines like the following
* https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/
* java-rest-high-ilm-ilm-delete-lifecycle-policy.html
Member
This is unfortunately because of the 140 character limit. It's a sad side effect. |
Contributor
Author
|
Opened #48089 for the test failure. |
Contributor
Author
|
The failing tests have been muted in master. |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Oct 16, 2019
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Oct 16, 2019
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Oct 16, 2019
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
gwbrown
added a commit
that referenced
this pull request
Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
gwbrown
added a commit
that referenced
this pull request
Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
gwbrown
added a commit
that referenced
this pull request
Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
gwbrown
added a commit
that referenced
this pull request
Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were not updated when the ILM HLRC documentation was written. This commit fixes those links.
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.