Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 10, 2019

If we roll translog but do not index, then a flush without force is a noop. In this case, the number of retained translog files will be higher than the value specified by the retention policy.

Closes #47597
Relates #47414

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.5.0 v6.8.4 v7.4.1 labels Oct 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

@dnhatn
Copy link
Member Author

dnhatn commented Oct 10, 2019

run elasticsearch-ci/packaging-sample

@dnhatn dnhatn requested a review from ywelsch October 11, 2019 12:53
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our favorite bug 🤣

@dnhatn
Copy link
Member Author

dnhatn commented Oct 12, 2019

Our favorite bug 🤣

Haha

@dnhatn dnhatn merged commit 6731e9f into elastic:master Oct 12, 2019
@dnhatn dnhatn deleted the fix-translog-policy-test branch October 12, 2019 01:09
dnhatn added a commit that referenced this pull request Oct 14, 2019
If we roll translog but do not index, then a flush without force is a 
noop. In this case, the number of retained translog files will be higher
than the value specified by the retention policy.

Closes #4741
dnhatn added a commit that referenced this pull request Oct 14, 2019
If we roll translog but do not index, then a flush without force is a 
noop. In this case, the number of retained translog files will be higher
than the value specified by the retention policy.

Closes #4741
dnhatn added a commit that referenced this pull request Oct 14, 2019
If we roll translog but do not index, then a flush without force is a 
noop. In this case, the number of retained translog files will be higher
than the value specified by the retention policy.

Closes #4741
howardhuanghua pushed a commit to TencentCloudES/elasticsearch that referenced this pull request Oct 14, 2019
If we roll translog but do not index, then a flush without force is a 
noop. In this case, the number of retained translog files will be higher
than the value specified by the retention policy.

Closes elastic#4741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v6.8.4 v7.4.1 v7.5.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Failure in IndexShardIT.testLimitNumberOfRetainingTranslogFiles

4 participants