-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Monitoring] Add new cluster privilege now necessary for the stack monitoring ui #47871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Add new cluster privilege now necessary for the stack monitoring ui #47871
Conversation
|
Pinging @elastic/es-core-features (:Core/Features/Monitoring) |
|
For anyone that runs into this issue, there is a workaround for those running 7.4.0 in the short term by creating a temporary, custom PUT /_security/role/fix_monitoring_user
{
"cluster": [
"cluster:monitor/remote/info"
]
}then adding it to your monitoring PUT /_security/user/my_monitoring_user
{
"username": "my_monitoring_user",
"roles": [
"kibana_user",
"monitoring_user",
"fix_monitoring_user"
],
"enabled": true,
"full_name": "My Monitoring User",
"email": "[email protected]"
}Note: this implies a user update, since there's no password. |
|
Based on my recent experience in opening a PR against these files, I think this may need to be reviewed by @elastic/es-security |
...core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStore.java
Outdated
Show resolved
Hide resolved
igoristic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 🥇
pickypg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to update tests in
https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java#L433, which conveniently will provide a chance to use @igoristic's recommendation in the test.
pickypg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm not sure how the ES team feels about mixing the constants with the static references, so I'll leave that for them to make a final ruling on.
|
There is precedent for doing this right now EDIT: updated link |
…nitoring ui (elastic#47871) * Add new cluster privilege now necessary for the stack monitoring ui * PR feedback, and add test
…nitoring ui (elastic#47871) * Add new cluster privilege now necessary for the stack monitoring ui * PR feedback, and add test
Resolves elastic/kibana#47859
We added a new call in the Stack Monitoring UI that requires this cluster privilege.
To test, create a user with the minimum permissions (roles=[
kibana_user,monitoring_user]) and ensure you can access the Stack Monitoring UI in Kibana