Remove include_relocations setting #47717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `cluster.routing.allocation.disk.include_relocations` to `false` is a bad idea since it will lead to the kinds of overshoot that were otherwise fixed in elastic#46079. This setting was deprecated in elastic#47443. This commit removes it.
DaveCTurner
added
>breaking
:Distributed Coordination/Allocation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
Contributor
Author
|
I opened #47718 for the CI failure. @elasticmachine please run elasticsearch-ci/docs-check |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 9, 2019
jloleysens
added a commit
to elastic/kibana
that referenced
this pull request
Oct 11, 2019
* First pass of spec update to OSS plugin * Update existing doc links * Move data_frame files to new depreceated namespace * Removing this setting per elastic/elasticsearch#47717 * Add new files * Added transforms overrides * Updated deprecated data transforms file names Fixed broken __template's Updated autocomplete for new transforms endpoints
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 11, 2019
* First pass of spec update to OSS plugin * Update existing doc links * Move data_frame files to new depreceated namespace * Removing this setting per elastic/elasticsearch#47717 * Add new files * Added transforms overrides * Updated deprecated data transforms file names Fixed broken __template's Updated autocomplete for new transforms endpoints
jloleysens
added a commit
to elastic/kibana
that referenced
this pull request
Oct 11, 2019
* First pass of spec update to OSS plugin * Update existing doc links * Move data_frame files to new depreceated namespace * Removing this setting per elastic/elasticsearch#47717 * Add new files * Added transforms overrides * Updated deprecated data transforms file names Fixed broken __template's Updated autocomplete for new transforms endpoints
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
May 31, 2021
…ELOCATIONS_SETTING Relates elastic#47717
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
cluster.routing.allocation.disk.include_relocationstofalseis abad idea since it will lead to the kinds of overshoot that were otherwise fixed
in #46079. This setting was deprecated in #47443. This commit removes it.