Skip to content

Conversation

@immon
Copy link
Contributor

@immon immon commented Oct 3, 2019

The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.

I understand that it meant to be a generic rollover example, but here we are in the context of ILM

The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.
@ywelsch ywelsch added :Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes labels Oct 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll wait for a review from a dev before merging.

Thanks @immon.

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 3f4be61 into master Oct 3, 2019
@jrodewig jrodewig deleted the immon-docpatch-ilm-1 branch October 3, 2019 13:25
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
The warning section above the example tells that index name has to end with the digits but the example itself uses index name without digits which is confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes v7.4.1 v7.5.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants