Remove groovy test code from buildSrc #47416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <[email protected]>
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Signed-off-by: Mark Vieira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seemed to have a
src/test/groovysource directory in our:buildSrcproject, probably just left over from a time when some unit tests were written in Groovy. Currently, there were only two source files in there, and only one of them was actually a Groovy file. Probably simpler to just throw everything insrc/test/java, and then we can ditch the need to runcompileTestGroovyat all which is a small speed bump in the build.