Skip to content

Conversation

@szabosteve
Copy link
Contributor

Related issue: https://github.com/elastic/ml-team/issues/187#issuecomment-536026064

This PR makes small structural changes on the update anomaly detection jobs API documentation to improve readability.

@szabosteve szabosteve added :ml Machine learning >docs General docs changes v7.3.3 v7.4.1 v7.5.0 v8.0.0 labels Sep 30, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@lcawl
Copy link
Contributor

lcawl commented Sep 30, 2019

I think the column delimiters have gotten out of synch. See the second row of the table in the preview here:
http://elasticsearch_47280.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/ml-update-job.html

@szabosteve
Copy link
Contributor Author

@lcawl Thanks for spotting this. There was an extra delimiter at the end of the first row. I removed it and checked the preview. It is okay now.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@szabosteve szabosteve merged commit aa7c403 into elastic:master Oct 2, 2019
@szabosteve szabosteve deleted the fix.ad.update branch October 2, 2019 08:04
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Oct 2, 2019
…stic#47280)

* [DOCS] Fine tunes update anomaly detection job API documentation.
* [DOCS] Removes delimiter to fix the table.
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Oct 2, 2019
…stic#47280)

* [DOCS] Fine tunes update anomaly detection job API documentation.
* [DOCS] Removes delimiter to fix the table.
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Oct 2, 2019
…stic#47280)

* [DOCS] Fine tunes update anomaly detection job API documentation.
* [DOCS] Removes delimiter to fix the table.
@szabosteve
Copy link
Contributor Author

Backported to 7.x, 7.4, and 7.3.

To backport further down, new PR is required due to changes in the folder structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants