Injected response errors in Azure repository tests should have a body #47176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
@elasticmachine update branch |
original-brownbear
approved these changes
Sep 26, 2019
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, thanks Tanguy!
Member
Author
|
Thanks Armin! |
tlrx
added a commit
that referenced
this pull request
Sep 27, 2019
…#47176) The Azure SDK client expects server errors to have a body, something that looks like: <?xml version="1.0" encoding="utf-8"?> <Error> <Code>string-value</Code> <Message>string-value</Message> </Error> I've forgot to add such errors in Azure tests and that triggers some NPE in the client like the one reported in #47120. Closes #47120
tlrx
added a commit
that referenced
this pull request
Oct 25, 2019
In #47176 we changed the internal HTTP server that emulates the Azure Storage service so that it includes a response body for injected errors. This fixed most of the issues reported in #47120 but sadly I missed to map one error to its Azure equivalent, and it triggered some CI failures today. Closes #47120
tlrx
added a commit
that referenced
this pull request
Oct 25, 2019
In #47176 we changed the internal HTTP server that emulates the Azure Storage service so that it includes a response body for injected errors. This fixed most of the issues reported in #47120 but sadly I missed to map one error to its Azure equivalent, and it triggered some CI failures today. Closes #47120
tlrx
added a commit
that referenced
this pull request
Oct 25, 2019
In #47176 we changed the internal HTTP server that emulates the Azure Storage service so that it includes a response body for injected errors. This fixed most of the issues reported in #47120 but sadly I missed to map one error to its Azure equivalent, and it triggered some CI failures today. Closes #47120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure SDK client expects server errors to have a body, something that looks like:
I've forgot to add such errors in Azure tests and that triggers some NPE in the client like the one reported in #47120.
Closes #47120