Allow optype CREATE for append-only indexing operations #47169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>enhancement
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
This is looking good already. I left a number of smaller comments to consider and/or address.
server/src/main/java/org/elasticsearch/action/index/IndexRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/test/bulk/11_basic_with_types.yml
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/document/DocumentActionsIT.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java
Outdated
Show resolved
Hide resolved
qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/IndexingIT.java
Outdated
Show resolved
Hide resolved
ywelsch
commented
Sep 30, 2019
server/src/main/java/org/elasticsearch/action/index/IndexRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Show resolved
Hide resolved
qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/IndexingIT.java
Outdated
Show resolved
Hide resolved
henningandersen
approved these changes
Sep 30, 2019
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
I think we should hold off on backporting until we have ensured that the engine properly handles op_type create requests with auto-id.
ywelsch
added a commit
that referenced
this pull request
Oct 1, 2019
ywelsch
added a commit
that referenced
this pull request
Oct 1, 2019
ywelsch
added a commit
that referenced
this pull request
Oct 1, 2019
ywelsch
added a commit
that referenced
this pull request
Oct 1, 2019
Adds support for handling auto-id requests with optype CREATE. Also simplifies the code handling this by using the standard indexing path when dealing with possible retry conflicts. Relates #47169
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Oct 2, 2019
Bulk requests currently do not allow adding "create" actions with auto-generated IDs. This commit allows using the optype CREATE for append-only indexing operations. This is mainly the user facing aspect of it.
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Oct 2, 2019
Adds support for handling auto-id requests with optype CREATE. Also simplifies the code handling this by using the standard indexing path when dealing with possible retry conflicts. Relates elastic#47169
ywelsch
added a commit
that referenced
this pull request
Oct 2, 2019
Bulk requests currently do not allow adding "create" actions with auto-generated IDs. This commit allows using the optype CREATE for append-only indexing operations. This is mainly the user facing aspect of it.
ywelsch
added a commit
that referenced
this pull request
Oct 2, 2019
Adds support for handling auto-id requests with optype CREATE. Also simplifies the code handling this by using the standard indexing path when dealing with possible retry conflicts. Relates #47169
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk requests currently do not allow adding "create" actions with auto-generated IDs. This PR allows using the optype CREATE for append-only indexing operations. This is mainly the user-facing aspect of it. Follow-ups will include:
POST index/_docshould be the optype CREATE.