-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Docs] Fix the numbering in the annotated_text example #47077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the references are rendered incorrectly
Collaborator
|
Pinging @elastic/es-search |
Collaborator
|
Pinging @elastic/es-docs |
cbuescher
approved these changes
Sep 25, 2019
Member
cbuescher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, very subtle error. Thanks for the correction. Will run some tests before merging.
Member
|
@elasticmachine test this please |
cbuescher
pushed a commit
that referenced
this pull request
Sep 25, 2019
cbuescher
pushed a commit
that referenced
this pull request
Sep 25, 2019
cbuescher
pushed a commit
that referenced
this pull request
Sep 25, 2019
cbuescher
pushed a commit
that referenced
this pull request
Sep 25, 2019
cbuescher
pushed a commit
that referenced
this pull request
Sep 25, 2019
cbuescher
pushed a commit
that referenced
this pull request
Sep 25, 2019
cbuescher
pushed a commit
that referenced
this pull request
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
:Search Foundations/Mapping
Index mappings, including merging and defining field types
v6.8.4
v7.0.2
v7.1.2
v7.2.2
v7.3.3
v7.4.0
v7.5.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the references in the example are rendered incorrectly. The numbering beneath the example are un-ordered and the explanation itself does not match the referenced number.