-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS] Merge monitoring sections in Elasticsearch book #46885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-core-features |
|
Pinging @elastic/es-docs |
debadair
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments, but LGTM
| @@ -0,0 +1,39 @@ | |||
| [role="xpack"] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this file is new, I'd align the filename with the top-level anchor.
| [testenv="basic"] | ||
| [[es-monitoring]] | ||
| = Monitoring {es} | ||
| [[monitor-cluster]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a top-level heading, I'd be inclined to be redundant and include "elasticsearch" in the anchor: [monitor-elasticsearch-cluster]. Similarly, I'd insert {es} before cluster in the paragraph below.
|
@lcawl I can no longer see the preview from the link you posted, I'm afraid. |
Sorry, the URL changed. See http://elasticsearch_46885.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/monitor-elasticsearch-cluster.html |
jrodewig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #46718
This PR creates a "Monitor a cluster" part at the top level of the Elasticsearch book, which contains the following existing content:
https://www.elastic.co/guide/en/elasticsearch/reference/master/es-monitoring.html
https://www.elastic.co/guide/en/elasticsearch/reference/master/configuring-monitoring.html
It also adds a brief introduction, which is copied from https://www.elastic.co/guide/en/elastic-stack-overview/master/xpack-monitoring.html
Additional content might be moved from the Stack Overview in subsequent PRs.
PREVIEW: http://elasticsearch_46885.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/monitor-elasticsearch-cluster.html