Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 19, 2019

Related to #46718

This PR creates a "Monitor a cluster" part at the top level of the Elasticsearch book, which contains the following existing content:
https://www.elastic.co/guide/en/elasticsearch/reference/master/es-monitoring.html
https://www.elastic.co/guide/en/elasticsearch/reference/master/configuring-monitoring.html

It also adds a brief introduction, which is copied from https://www.elastic.co/guide/en/elastic-stack-overview/master/xpack-monitoring.html

Additional content might be moved from the Stack Overview in subsequent PRs.

PREVIEW: http://elasticsearch_46885.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/monitor-elasticsearch-cluster.html

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig mentioned this pull request Sep 19, 2019
17 tasks
@lcawl lcawl marked this pull request as ready for review September 20, 2019 18:40
@lcawl lcawl requested review from cachedout and jrodewig September 20, 2019 18:40
@lcawl lcawl removed the WIP label Sep 20, 2019
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments, but LGTM

@@ -0,0 +1,39 @@
[role="xpack"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this file is new, I'd align the filename with the top-level anchor.

[testenv="basic"]
[[es-monitoring]]
= Monitoring {es}
[[monitor-cluster]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a top-level heading, I'd be inclined to be redundant and include "elasticsearch" in the anchor: [monitor-elasticsearch-cluster]. Similarly, I'd insert {es} before cluster in the paragraph below.

@cachedout
Copy link
Contributor

@lcawl I can no longer see the preview from the link you posted, I'm afraid.

@lcawl
Copy link
Contributor Author

lcawl commented Sep 23, 2019

@lcawl I can no longer see the preview from the link you posted, I'm afraid.

Sorry, the URL changed. See http://elasticsearch_46885.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/monitor-elasticsearch-cluster.html

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit a2e7dab into elastic:master Sep 24, 2019
@lcawl lcawl deleted the monitor-cluster branch September 24, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants