update _common.json format #46872
Merged
update _common.json format #46872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
cc @elastic/es-clients |
API spec now use an object for the documentation field. _common was not updated yet. This commit updates _common.json and its corresponding parser. Closes elastic#46744
delvedor
approved these changes
Sep 19, 2019
Member
delvedor
left a comment
delvedor
left a comment
There was a problem hiding this comment.
LGTM, this should also be backported to 7.x :)
delvedor
reviewed
Sep 19, 2019
rest-api-spec/src/main/resources/rest-api-spec/api/_common.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/_common.json
Outdated
Show resolved
Hide resolved
javanna
force-pushed
the
spec/update_common_parsing_format
branch
from
2d90971 to
7f5f308
Compare
Co-Authored-By: Tomas Della Vedova <[email protected]>
Co-Authored-By: Tomas Della Vedova <[email protected]>
javanna
added a commit
that referenced
this pull request
Sep 23, 2019
API spec now use an object for the documentation field. _common was not updated yet. This commit updates _common.json and its corresponding parser. Closes #46744 Co-Authored-By: Tomas Della Vedova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API spec now use an object for the documentation field. _common was not updated yet. This commit updates _common.json and its corresponding parser.
Closes #46744