Make Snapshot Logic Write Metadata after Segments (#45689) #46764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Write metadata during snapshot finalization after segment files to prevent outdated metadata in case of dynamic mapping updates as explained in elastic#41581 * Keep the old behavior of writing the metadata beforehand in the case of mixed version clusters for BwC reasons * Still overwrite the metadata in the end, so even a mixed version cluster is fixed by this change if a newer version master does the finalization * Fixes elastic#41581
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
Jenkins run elasticsearch-ci/default-distro |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 17, 2019
Disabling BwC test so we can safely merge elastic#46764
original-brownbear
added a commit
that referenced
this pull request
Sep 17, 2019
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 17, 2019
Now that elastic#46764 is merged tests can be reenabled
original-brownbear
added a commit
that referenced
this pull request
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #45689