Disallow _field_names enabled setting
#46681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After deprecating the setting starting with 7.5 in elastic#42854, this change disallows setting enabled for the `_field_names` field on new indices. The setting continues to work for indices created in 7.x where we still emit a deprecation warning.
cbuescher
added
>breaking
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search |
jtibshirani
approved these changes
Sep 12, 2019
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
Looks good to me -- just made a couple notes about typos that would be good to fix before merging.
server/src/test/java/org/elasticsearch/index/mapper/FieldNamesFieldMapperTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/FieldNamesFieldMapper.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 23, 2019
This change adds a check to the migration tool that warns about the deprecated "enabled" setting for the "_field_names" field on 7.x indices and issues a critical error for templates containing this setting, since it has been removed with 8.0. Relates to elastic#42854, elastic#46681
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deprecating the setting starting with 7.5 in #42854, this change disallows
setting enabled for the
_field_namesfield on new indices. The settingcontinues to work for indices created in 7.x where we still emit a deprecation
warning.