Rest Controller wildcard registration #46487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering two different http methods on the same path using different wildcard names would result in the last wildcard name being active only. Now throw an exception instead. Closes elastic#46482
henningandersen
added
>non-issue
:Core/Infra/REST API
Collaborator
|
Pinging @elastic/es-core-infra |
dakrone
approved these changes
Sep 9, 2019
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM I left one comment about the test
| IllegalArgumentException exception = expectThrows(IllegalArgumentException.class, | ||
| () -> restController.registerHandler(secondMethod, path + "/{wildcard2}", handler)); | ||
|
|
||
| assertThat(exception.getMessage(), containsString("wildcard1")); |
Member
There was a problem hiding this comment.
I think since we know the exact exception text that it would be good to check it here, otherwise it's possible a different exception in the future could be thrown but this test wouldn't break.
Something like:
assertThat(exception.getMessage(), equalTo("Trying to use conflicting wildcard names for same path: wildcard1 and wildcard2"))
Contributor
Author
|
Thanks for reviewing @dakrone |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
henningandersen
added a commit
that referenced
this pull request
Sep 9, 2019
Registering two different http methods on the same path using different wildcard names would result in the last wildcard name being active only. Now throw an exception instead. Closes #46482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering two different http methods on the same path using different
wildcard names would result in the last wildcard name being active only.
Now throw an exception instead.
Closes #46482