Ensure no ongoing peer recovery in translog yaml test #46476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
Thanks @DaveCTurner. |
dnhatn
added a commit
that referenced
this pull request
Sep 10, 2019
We leave replicas unassigned until we reroute after the primary shard starts. If a cluster health request with wait_for_no_initializing_shards is executed before the reroute, it will return immediately although there will be some initializing replicas. Peer recoveries of those shards can prevent translog on the primary from trimming. We add wait_for_events to the cluster health request so that it will execute after the reroute. Closes #46425
dnhatn
added a commit
that referenced
this pull request
Sep 11, 2019
We leave replicas unassigned until we reroute after the primary shard starts. If a cluster health request with wait_for_no_initializing_shards is executed before the reroute, it will return immediately although there will be some initializing replicas. Peer recoveries of those shards can prevent translog on the primary from trimming. We add wait_for_events to the cluster health request so that it will execute after the reroute. Closes #46425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We leave replicas unassigned until we reroute after the primary shard starts. If a cluster health request with
wait_for_no_initializing_shardsis executed before the reroute, it will return immediately although there will be some initializing replicas. Peer recoveries of those shards can prevent translog on the primary from trimming.We add
wait_for_eventsto the cluster health request so that it will execute after the reroute.Closes #46425