Add HLRC support for delete policy api #45833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also adds HLRC docs. Relates to elastic#32789
martijnvg
added
>non-issue
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features |
hub-cap
approved these changes
Aug 22, 2019
Contributor
hub-cap
left a comment
hub-cap
left a comment
There was a problem hiding this comment.
I sure do love reviewing AcknowledgedResponse HLRC APIs :)
| @Override | ||
| public void onResponse(AcknowledgedResponse response) { // <1> | ||
| boolean isAcknowledged = | ||
| deletePolicyResponse.isAcknowledged(); |
Contributor
There was a problem hiding this comment.
this should be response not deletePolicyResponse methinks
Member
Author
There was a problem hiding this comment.
good catch. I copied this from the put policy test and there the same mistake was made too :)
Member
Author
|
@elasticmachine run elasticsearch-ci/1 |
martijnvg
added a commit
that referenced
this pull request
Aug 26, 2019
This PR also adds HLRC docs. Relates to #32789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds HLRC docs.
Relates to #32789