Acknowledge Indices Were Wiped Successfully in REST Tests #45832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In internal test clusters tests we check that wiping all indices was acknowledged but in REST tests we didn't. This aligns the behavior in both kinds of tests. Relates elastic#45605 which might be caused by unacked deletes that were just slow.
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
alpar-t
approved these changes
Aug 22, 2019
Contributor
alpar-t
left a comment
alpar-t
left a comment
There was a problem hiding this comment.
LGTM
Might want to be careful with this one, could lead to more flakiness
Contributor
Author
|
thanks @atorok !
If it actually does, then I'd suggest to just increase the master ack timeout to |
Contributor
Author
|
Jenkins run elasticsearch-ci/bwc (Jenkins shut down) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 22, 2019
) In internal test clusters tests we check that wiping all indices was acknowledged but in REST tests we didn't. This aligns the behavior in both kinds of tests. Relates elastic#45605 which might be caused by unacked deletes that were just slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In internal test clusters tests we check that wiping all indices was acknowledged
but in REST tests we didn't.
This aligns the behavior in both kinds of tests.
Relates #45605 which might be caused by unacked deletes that were just slow.