Deprecate es.http.cname_in_publish_address setting #45616
Conversation
andrershov
added
the
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed |
There was a problem hiding this comment.
@andrershov Thanks for finding this!
I think we can't just remove this in the first PR? See the plan in #32806 (review) we need to first adjust the deprecation logging to say that this property does not have an effect anymore (and actually make it so like you did here). Then in another PR to master only we can remove that deprecation logging as well.
-> just keep the deprecation logger + adjust the message + then do a follow up ?
|
@original-brownbear correct, we need to log deprecation warning if the property is specified in 7.x. |
|
run elasticsearch-ci/1 |
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGMT after fixing the formatting change.
| new TransportAddress(localhost, port) | ||
| ), 0L, false | ||
| ), NetworkAddress.format(localhost) + ':' + port | ||
| new HttpInfo( |
There was a problem hiding this comment.
Revert noisy formatting change
andrershov
changed the title
Follow up on #32806. The system property es.http.cname_in_publish_address is deprecated starting from 7.0.0 and deprecation warning should be added if the property is specified. This PR will go to 7.x and master. Follow-up PR to remove es.http.cname_in_publish_address property completely will go to the master. (cherry picked from commit a5ceca7)
…5616) Follow up on elastic#32806. The system property es.http.cname_in_publish_address is deprecated starting from 7.0.0 and deprecation warning should be added if the property is specified. This PR will go to 7.x and master. Follow-up PR to remove es.http.cname_in_publish_address property completely will go to the master.
Follow-up of #45616. Starting with 8.0.0 es.http.cname_in_publish_address setting support is completely removed.
4 participants
Follow up on #32806.
The system property
es.http.cname_in_publish_addressis deprecated starting from 7.0.0 and deprecation warning should be added if the property is specified.This PR will go to 7.x and master.
Follow-up PR to remove es.http.cname_in_publish_address property completely will go to the master.