Use dynamic port ranges for ExternalTestCluster #45601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpar-t
added
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
Collaborator
|
Pinging @elastic/es-distributed |
Moves methods added in elastic#44213 and uses them to configure the port range for `ExternalTestCluster` too. These were still using `9300-9400` ( teh default ) and running into races.
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
Contributor
Author
|
Since this is expected to improve CI stability I am going to go ahead and merge it, but further feedback is much welcome I will address it in a new PR. |
alpar-t
added a commit
that referenced
this pull request
Aug 15, 2019
Moves methods added in #44213 and uses them to configure the port range for `ExternalTestCluster` too. These were still using `9300-9400` ( teh default ) and running into races.
alpar-t
added a commit
that referenced
this pull request
Aug 15, 2019
Moves methods added in #44213 and uses them to configure the port range for `ExternalTestCluster` too. These were still using `9300-9400` ( teh default ) and running into races.
alpar-t
added a commit
that referenced
this pull request
Aug 16, 2019
Extends #45601 to cover all tests.
alpar-t
added a commit
that referenced
this pull request
Aug 16, 2019
Extends #45601 to cover all tests.
alpar-t
added a commit
that referenced
this pull request
Aug 16, 2019
Extends #45601 to cover all tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves methods added in #44213 and uses them to configure the port range
for
ExternalTestClustertoo.These were still using
9300-9400( the default ) and running intoraces.