removes the CellIdSource abstraction from geo-grid aggs #45307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CellIdSource is a helper ValuesSource that encodes GeoPoint into a long-encoded representation of the grid bucket the point is associated with. This complicates thing as usage evolves to support shapes that are associated with more than one bucket ordinal.
talevy
added
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo |
talevy
commented
Aug 7, 2019
| for (int i = 0; i < valuesCount; ++i) { | ||
| final long val = values.nextValue(); | ||
| final GeoPoint point = values.nextValue(); | ||
| final long val = longEncoder.encode(point.getLon(), point.getLat(), precision); |
Contributor
Author
There was a problem hiding this comment.
the main reason for this change is so that more than one bucket can be added to bucketOrds per doc-value.
Contributor
|
🎉 |
talevy
added a commit
that referenced
this pull request
Aug 9, 2019
talevy
added a commit
that referenced
this pull request
Aug 9, 2019
…)" This reverts commit f114ef6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CellIdSource is a helper ValuesSource that encodes GeoPoint
into a long-encoded representation of the grid bucket the point
is associated with. This complicates thing as usage evolves to
support shapes that are associated with more than one bucket ordinal.