Upgrade to Netty 4.1.38 #45132
Merged
Upgrade to Netty 4.1.38 #45132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
original-brownbear
commented
Aug 2, 2019
original-brownbear
commented
- A number of fixes to buffer handling in the .37 and .38 -> we should stay up to date
* A number of fixes to buffer handling in the .37 and .38 -> we should stay up to date
original-brownbear
added
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed |
Tim-Brooks
reviewed
Aug 3, 2019
Contributor
Tim-Brooks
left a comment
Tim-Brooks
left a comment
There was a problem hiding this comment.
LGTM, but this should not be released in a release version of Elasticsearch without #44837. 4.1.37 starts using direct buffers on the read path and we need to mitigate that.
Tim-Brooks
approved these changes
Aug 3, 2019
Contributor
Author
|
@tbrooks8 thanks, I'll hold off merging this one until #44837 is merged then :) |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
Jenkins run elasticsearch-ci/2 |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 9, 2019
* A number of fixes to buffer handling in the .37 and .38 -> we should stay up to date
original-brownbear
added a commit
that referenced
this pull request
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.