Skip to content

Conversation

@tlrx
Copy link
Member

@tlrx tlrx commented Jul 26, 2019

This pull request adds a deprecation warning in 7.x for the Force Merge API when both only_expunge_deletes and max_num_segments are set in a request.

Relates #44761

@tlrx tlrx added >non-issue :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v7.4.0 labels Jul 26, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@tlrx tlrx unassigned dnhatn Jul 26, 2019
@tlrx tlrx requested a review from dnhatn July 26, 2019 16:06
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx
Copy link
Member Author

tlrx commented Aug 5, 2019

@elasticmachine run elasticsearch-ci/bwc

3 similar comments
@tlrx
Copy link
Member Author

tlrx commented Aug 5, 2019

@elasticmachine run elasticsearch-ci/bwc

@tlrx
Copy link
Member Author

tlrx commented Aug 5, 2019

@elasticmachine run elasticsearch-ci/bwc

@tlrx
Copy link
Member Author

tlrx commented Aug 6, 2019

@elasticmachine run elasticsearch-ci/bwc

@tlrx
Copy link
Member Author

tlrx commented Aug 6, 2019

@elasticmachine run elasticsearch-ci/bwc

1 similar comment
@tlrx
Copy link
Member Author

tlrx commented Aug 6, 2019

@elasticmachine run elasticsearch-ci/bwc

@tlrx tlrx merged commit 772ce1f into elastic:7.x Aug 6, 2019
@tlrx tlrx deleted the add-deprecation-warning-force-merge branch August 6, 2019 14:04
@tlrx
Copy link
Member Author

tlrx commented Aug 6, 2019

Thanks @dnhatn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue v7.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants