[ML-DataFrame] do not assert on indexer state #44854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
added
>test-failure
Collaborator
|
Pinging @elastic/ml-core |
hendrikmuhs
pushed a commit
that referenced
this pull request
Jul 25, 2019
remove the unreliable check for the state change fixes #44813
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
remove the unreliable check for the state change fixes #44813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the unreliable check for the state change
fixes #44813
What happened in the test failure:
There are 2 threads involved, A the managing thread(the test code), B the indexer thread. A triggers B to change the state to
INDEXINGand start the work. In this test B is supposed to do 5 iterations and then finish. What happened in the failure is that B changed state toINDEXING, ran 5 times and by design switched back toSTARTEDbefore A checked the state (the offending line). In other tests we do the same but sync B using a latch, so it does not finish before the latch is counted down.Checking the indexer state is not the main purpose of this test, additionally we cover this case already in other tests, therefore removing the offending line is proper way to fix, we do not loose coverage.
The test in question has been added in 7.4, so no further backport than 7.4 required.