Treat PostDataActionResponse.DataCounts.bucketCount as incremental rather than absolute (total). #44803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
przemekwitek
force-pushed
the
accept_incremental_bucket_count
branch
from
46a0fbc to
1204a73
Compare
…ther than absolute (total).
przemekwitek
force-pushed
the
accept_incremental_bucket_count
branch
from
1204a73 to
341976a
Compare
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jul 25, 2019
…ther than absolute (total). (elastic#44803)
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
…ther than absolute (total). (#44803)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostDataActionResponse.DataCounts.bucketCount was treated as absolute (total) so far. This could have caused consecutive averages being unrelated to each other, hence significantly different.
This in turn causes a lot of document updates and overall slowness.
This PR fixes the bug with the hope the performance will go back to normal.
Related to #44792