Skip to content

Conversation

@jkakavas
Copy link
Contributor

Handle version parsing more leniently in RestClientBuilder for the
cases where TLS version pinning is required since we cannot use
JavaVersion here.

This became an issue after merging #44017

Handle version parsing more leniently in RestClientBuilder for the
cases where TLS version pinning is required since we cannot use
JavaVersion here.
@jkakavas jkakavas added >test-failure Triaged test failures from CI v8.0.0 v7.4.0 v7.3.1 labels Jul 23, 2019
@jkakavas jkakavas requested a review from jasontedor July 23, 2019 08:54
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jkakavas jkakavas merged commit beb6607 into elastic:master Jul 23, 2019
jkakavas added a commit that referenced this pull request Jul 23, 2019
Handle version parsing more leniently in RestClientBuilder for the
cases where TLS version pinning is required since we cannot use
JavaVersion here.
jkakavas added a commit that referenced this pull request Jul 23, 2019
Handle version parsing more leniently in RestClientBuilder for the
cases where TLS version pinning is required since we cannot use
JavaVersion here.
@jpountz jpountz added v7.3.0 and removed v7.3.1 labels Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants