Don't use TypeField for nested filters #44482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search |
jpountz
approved these changes
Jul 18, 2019
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
It's important for the query that identifies root documents to be fast and avoid pure negations, but I think it's fine for the query that identifies nested documents.
s1monw
approved these changes
Jul 22, 2019
Contributor
Author
|
I'm not going to backport this to 7.x, as |
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
We changed things in #27469 to filter parent docs by using an exists query on the primary_term field. However, the equivalent query for nested documents is still using the type field. This commit makes newNestedFilter build the complement of newNonNestedFilter instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed things in #27469 to filter parent
docs by using an exists query on the
primary_termfield. However, the equivalent queryfor nested documents is still using the type field. This commit makes
newNestedFilterbuild the complement of
newNonNestedFilterinstead.