Add CloseIndexResponse to HLRC #44349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-features |
dnhatn
reviewed
Jul 16, 2019
| @SuppressWarnings("unchecked") | ||
| private static final ConstructingObjectParser<IndexResult, String> PARSER = new ConstructingObjectParser<>("index_result", true, | ||
| (args, name) -> { | ||
| final Index index = new Index(name, "_na_"); |
Member
There was a problem hiding this comment.
I think we should avoid using dummy UUIDs in the production code (if possible). However, making IndexResult accept an index name would not be easy now as it will break BWC.
Member
Author
This reverts commit 86e9926
Member
Author
|
@dnhatn I reverted my changes and I created dedicated objects for the HLRC close index response. This duplicates some logic (mostly in tests) but I think it's cleaner now. Can you please have another look? |
Member
Author
|
@elasticmachine update branch |
Member
|
@elasticmachine update branch |
dnhatn
approved these changes
Jul 24, 2019
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the extra iteration.
Member
Author
|
Thanks a lot @dnhatn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We improved the
CloseIndexResponsein #39687; this pull request exposes it in the HLRC. It also improves the test coverage by usingAbstractWireSerializingTestCaseandAbstractResponseTestCase.