Some Cleanup in o.e.i.shard #44097
Merged
Some Cleanup in o.e.i.shard #44097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
original-brownbear
commented
Jul 9, 2019
original-brownbear
commented
- Extract one duplicated method
- Remove long obsolete BwC logic
- Cleanup obviously unused code
* Extract one duplicated method * Cleanup obviously unused code
original-brownbear
added
>non-issue
:Distributed Indexing/Store
Collaborator
|
Pinging @elastic/es-distributed |
henningandersen
approved these changes
Jul 9, 2019
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
I left a couple of minor comments to consider.
server/src/main/java/org/elasticsearch/index/cache/bitset/BitsetFilterCache.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
thanks @henningandersen ! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 11, 2019
* Some Cleanup in o.e.i.shard * Extract one duplicated method * Cleanup obviously unused code
original-brownbear
added a commit
that referenced
this pull request
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.