Skip to content

Remove IncompatibleSnapshots Logic from Codebase #44096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2019
Merged

Remove IncompatibleSnapshots Logic from Codebase #44096

merged 3 commits into from
Jul 9, 2019

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Jul 9, 2019

  • The incompatible snapshots logic was created to track 1.x snapshots that
    became incompatible with 2.x
    • It serves no purpose at this point
    • It adds an additional GET request to every loading of
      RepositoryData (from loading the incompatible snapshots blob)

@original-brownbear
Remove IncompatibleSnapshots Logic from Codebase
ecff244 
* The incompatible snapshots logic was created to track 1.x snapshots that
became incompatible with 2.x
   * It serves no purpose at this point
   * It adds an additional GET request to every loading of
RepositoryData (from loading the incompatible snapshots blob)
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 9, 2019

Pinging @elastic/es-distributed

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jul 9, 2019

Jenkins run elasticsearch-ci/packaging-sample

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jul 9, 2019

Jenkins run elasticsearch-ci/1

tlrx
tlrx approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm happy to see these gone

server/src/main/java/org/elasticsearch/repositories/RepositoryData.java
} else {
throw new ElasticsearchParseException("start object expected");
}
return new RepositoryData(this.genId, this.snapshotIds, this.snapshotStates, this.indexSnapshots, incompatibleSnapshotIds);
Copy link
Member

@tlrx tlrx Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove incompatibleSnapshotIds from RepositoryData too?

Copy link
Contributor Author

@original-brownbear original-brownbear Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right ... on it :)

Copy link
Contributor Author

@original-brownbear original-brownbear Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the field and all users of it :)

@original-brownbear original-brownbear requested a review from tlrx July 9, 2019 08:24
tlrx
tlrx approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jul 9, 2019

thanks @tlrx :)

@original-brownbear original-brownbear merged commit 6e9642b into elastic:master Jul 9, 2019
@original-brownbear original-brownbear deleted the no-more-incompatible-snapshots branch July 9, 2019 11:07
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 10, 2019
@original-brownbear
Remove IncompatibleSnapshots Logic from Codebase (elastic#44096)
4674245 
* The incompatible snapshots logic was created to track 1.x snapshots that
became incompatible with 2.x
   * It serves no purpose at this point
   * It adds an additional GET request to every loading of
RepositoryData (from loading the incompatible snapshots blob)
@original-brownbear original-brownbear mentioned this pull request Jul 10, 2019
Merged
original-brownbear added a commit that referenced this pull request Jul 11, 2019
@original-brownbear
Remove IncompatibleSnapshots Logic from Codebase (#44096) (#44183)
8a554f9 
* The incompatible snapshots logic was created to track 1.x snapshots that
became incompatible with 2.x
   * It serves no purpose at this point
   * It adds an additional GET request to every loading of
RepositoryData (from loading the incompatible snapshots blob)
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 29, 2019
@original-brownbear
Mute testParallelRestoreOperations on 7.3
7a71ee2 
* For elastic#44630, this is already fixed in 7.4+ via elastic#44096 so I'd just mute it in 7.3 and 7.2
* The failure in in elastic#44630 is an exclusive result of of concurrently trying to create the `incompatible-snapshots` snapshots blob whihc isn't an issue in production because the blob would exist there anyway
@original-brownbear original-brownbear mentioned this pull request Jul 29, 2019
Merged
original-brownbear added a commit that referenced this pull request Jul 29, 2019
@original-brownbear
Mute testParallelRestoreOperations in 7.3 (#44962)
a2ea200 
* Mute testParallelRestoreOperations on 7.3

* For #44630, this is already fixed in 7.4+ via #44096 so I'd just mute it in 7.3 and 7.2, 6.8
* The failure in in #44630 is an exclusive result of of concurrently trying to create the `incompatible-snapshots` snapshots blob whihc isn't an issue in production because the blob would exist there anyway
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 29, 2019
@original-brownbear
Mute testParallelRestoreOperations in 7.2 (elastic#44962)
4d4ec6a 
* Mute testParallelRestoreOperations on 7.2

* For elastic#44630, this is already fixed in 7.4+ via elastic#44096 so I'd just mute it in 7.3 and 7.2, 6.8
* The failure in in elastic#44630 is an exclusive result of of concurrently trying to create the `incompatible-snapshots` snapshots blob whihc isn't an issue in production because the blob would exist there anyway
@original-brownbear original-brownbear mentioned this pull request Jul 29, 2019
Merged
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 29, 2019
@original-brownbear
Mute testParallelRestoreOperations in 6.8 (elastic#44962)
786038b 
* Mute testParallelRestoreOperations on 6.8

* For elastic#44630, this is already fixed in 7.4+ via elastic#44096 so I'd just mute it in 7.3 and 7.2, 6.8
* The failure in in elastic#44630 is an exclusive result of of concurrently trying to create the `incompatible-snapshots` snapshots blob whihc isn't an issue in production because the blob would exist there anyway
@original-brownbear original-brownbear mentioned this pull request Jul 29, 2019
Merged
original-brownbear added a commit that referenced this pull request Jul 29, 2019
@original-brownbear
Mute testParallelRestoreOperations in 7.2 (#44962) (#44965)
1943444 
* Mute testParallelRestoreOperations on 7.2

* For #44630, this is already fixed in 7.4+ via #44096 so I'd just mute it in 7.3 and 7.2, 6.8
* The failure in in #44630 is an exclusive result of of concurrently trying to create the `incompatible-snapshots` snapshots blob whihc isn't an issue in production because the blob would exist there anyway
original-brownbear added a commit that referenced this pull request Jul 29, 2019
@original-brownbear
Mute testParallelRestoreOperations in 6.8 (#44962) (#44966)
d5fca1e 
* Mute testParallelRestoreOperations on 6.8

* For #44630, this is already fixed in 7.4+ via #44096 so I'd just mute it in 7.3 and 7.2, 6.8
* The failure in in #44630 is an exclusive result of of concurrently trying to create the `incompatible-snapshots` snapshots blob whihc isn't an issue in production because the blob would exist there anyway
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 31, 2019
@original-brownbear
Reenable Parallel Restore Test on Windows
292b8b0 
* As a result of elastic#44096 this test shouldn't fail anymore on `master` and `7.4`+ so we should reenable it there
  * For older versions we won't backport that change so the tests should stay disabled there
* Closes elastic#44671
@original-brownbear original-brownbear mentioned this pull request Jul 31, 2019
Merged
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 31, 2019
@original-brownbear
Reenable Parallel Restore Test on Windows (elastic#45037)
6b8014b 
* As a result of elastic#44096 this test shouldn't fail anymore on `master` and `7.4`+ so we should reenable it there
  * For older versions we won't backport that change so the tests should stay disabled there
* Closes elastic#44671
original-brownbear added a commit that referenced this pull request Jul 31, 2019
@original-brownbear
Reenable Parallel Restore Test on Windows (#45037)
cc10723 
* As a result of #44096 this test shouldn't fail anymore on `master` and `7.4`+ so we should reenable it there
  * For older versions we won't backport that change so the tests should stay disabled there
* Closes #44671
@original-brownbear original-brownbear mentioned this pull request Jul 31, 2019
Merged
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
@original-brownbear @jkakavas
Reenable Parallel Restore Test on Windows (#45037)
cc53cc4 
* As a result of #44096 this test shouldn't fail anymore on `master` and `7.4`+ so we should reenable it there
  * For older versions we won't backport that change so the tests should stay disabled there
* Closes #44671
original-brownbear added a commit that referenced this pull request Jul 31, 2019
@original-brownbear
Reenable Parallel Restore Test on Windows (#45037) (#45050)
ee663dc 
* As a result of #44096 this test shouldn't fail anymore on `master` and `7.4`+ so we should reenable it there
  * For older versions we won't backport that change so the tests should stay disabled there
* Closes #44671
mkleen added a commit to crate/crate that referenced this pull request Jun 22, 2020
@mkleen
Remove obsolete IncompatibleSnapshots Logic
1319dfd 
Backport of elastic/elasticsearch#44096
@mkleen mkleen mentioned this pull request Jun 22, 2020
Merged
5 tasks
mkleen added a commit to crate/crate that referenced this pull request Jun 22, 2020
@mkleen
Remove obsolete IncompatibleSnapshots Logic
6aef060 
Based on elastic/elasticsearch#44096
mergify bot pushed a commit to crate/crate that referenced this pull request Jun 22, 2020
@mkleen @mergify
Remove obsolete IncompatibleSnapshots Logic
2dc66e3 
Based on elastic/elasticsearch#44096
@original-brownbear original-brownbear restored the no-more-incompatible-snapshots branch August 6, 2020 18:22
@kingherc kingherc mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrx tlrx tlrx approved these changes

@ywelsch ywelsch Awaiting requested review from ywelsch

Assignees

No one assigned

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue v7.4.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@original-brownbear @elasticmachine @tlrx @jakelandis