Add SAS Token Authentication Support to Azure Repo Plugin #43841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) (elastic#43618) * Added setting for SAS token * Added support for the token in tests * Relates elastic#42117
| return name; | ||
| } | ||
|
|
||
| public String getKey() { |
Contributor
Author
There was a problem hiding this comment.
I removed this API here as well as adding the key to the toString output, just like it was done in master when SAS token support was added.
Contributor
Author
|
@ywelsch can you double check this one? Just asking because it's 6.8 and wasn't a clean backport (required a bit of moving around with the constructors of the settings class since we have some additional legacy settings in 6.8, other than that it went pretty clean now that we have the renaming 6.8). I also manually verified that 3rd party tests still work with key as well as SAS token auth :) |
Contributor
Author
|
Jenkins run elasticsearch-ci/2 |
Contributor
Author
|
thanks @ywelsch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #42982