[ML][Data Frame] fix progress measurement for continuous transforms #43838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
hendrikmuhs
reviewed
Jul 1, 2019
| protected void onFinish(ActionListener<Void> listener) { | ||
| // reset the page size, so we do not memorize a low page size forever, the pagesize will be re-calculated on start | ||
| pageSize = 0; | ||
| pageSize = pivot.getInitialPageSize(); |
There was a problem hiding this comment.
I find it more logical to re-calc it at start (line 118). It doesn't matter right now but maybe in future the page size calculation depends on a setting or entails some more other data dependent calculation.
There was a problem hiding this comment.
so the comment "the pagesize will be re-calculated on start" is not true anymore after this change
Member
Author
|
run elasticsearch-ci/1 |
1 similar comment
Member
Author
|
run elasticsearch-ci/1 |
Member
Author
|
@elasticmachine update branch |
|
run elasticsearch-ci/1 |
Member
Author
|
elasticsearch-ci/1 |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
run elasticsearch-ci/packaging-sample |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jul 2, 2019
…lastic#43838) * [ML][Data Frame] fix progress measurement for continuous transforms * Update DataFrameIndexer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress is now reset on every new checkpoint.
Some refactoring was necessary so that the changed buckets could be determined BEFORE we reset the progress statistics.