[ML][Data Frame] Add deduced mappings to _preview response payload #43742
Conversation
|
Pinging @elastic/ml-core |
hendrikmuhs
left a comment
hendrikmuhs
left a comment
There was a problem hiding this comment.
1 question, looks good otherwise.
Wondering about check in: do not we have to use Version.Current and change it to 7.3.0 in a followup to not break BWC?
| out.writeMapWithConsistentOrder(doc); | ||
| } | ||
| if (out.getVersion().onOrAfter(Version.V_7_3_0)) { | ||
| out.writeMap(mappings); |
There was a problem hiding this comment.
it seems mappings can be null, so would it make sense to use optional?
There was a problem hiding this comment.
@hendrikmuhs writeMap and readMap when it is just a Map<String,Object> handles null values internally.
There are also no BWC tests yet...still waiting on PR: #43506
There was a problem hiding this comment.
ok checked it, implicit magic, well...
| out.writeMapWithConsistentOrder(doc); | ||
| } | ||
| if (out.getVersion().onOrAfter(Version.V_7_3_0)) { | ||
| out.writeMap(mappings); |
There was a problem hiding this comment.
ok checked it, implicit magic, well...
|
run elasticsearch-ci/1 |
|
@elasticmachine update branch |
…lastic#43742) * [ML][Data Frame] Add deduced mappings to _preview response payload * updating preview docs
4 participants
This updates the
_previewresponse payload to include the deduced mappings. The "mapping" format returned fromPivot#deduceMappingshas a non-standard format of{"field1": "field1Type", "field2.subfield": "field2.subfieldType"}. So, I opted to transform it so that it is in an appropriate format ofRelated to: elastic/kibana#39250