Issue deprecation warnings for preconfigured delimited_payload_filter #43684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>bug
:Search Relevance/Analysis
Collaborator
|
Pinging @elastic/es-search |
cbuescher
reviewed
Jun 27, 2019
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
LGTM. Should this also go back to the 7.2 branch?
Contributor
Author
Yes, good idea |
romseygeek
added a commit
that referenced
this pull request
Jun 27, 2019
…r is used (#43684) that warnings would be emitted when both a normal and pre-configured filter were used. Unfortunately, due to a bug in the Analyze API, the pre- configured filter check was never actually triggered, and it turns out that the deprecation warning was not in fact being emitted in this case. This commit ensures that the preconfigured filter also emits the warnings and triggers an error if a new index tries to use a preconfigured delimited_payload_filter
pull bot
pushed a commit
to sadlil/elasticsearch
that referenced
this pull request
Jun 27, 2019
elastic#41560 removed the delimited_payload_filter as part of a general cleanup of pre-version 7 restrictions, but missed removing the preconfigured version due to elastic#43684.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26625 deprecated
delimited_payload_filterand added tests to checkthat warnings would be emitted when both a normal and pre-configured
filter were used. Unfortunately, due to a bug in the Analyze API, the pre-
configured filter check was never actually triggered, and it turns out that
the deprecation warning was not in fact being emitted in this case.
#43568 fixed the Analyze API bug, which then surfaced this on backport.
This commit ensures that the preconfigured filter also emits the warnings
and triggers an error if a new index tries to use a preconfigured
delimited_payload_filter