Improve CryptoService error message on missing secure file #43623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the error message when encrypting of sensitive watcher data is configured, but no system file was specified in the keystore. This error message is displayed on startup. This also closes the input stream of the secure file properly. Closes elastic#43619
Collaborator
|
Pinging @elastic/es-core-features |
Member
|
@elasticmachine update branch |
Member
|
@elasticmachine run elasticsearch-ci/2 |
Member
|
@elasticmachine run elasticsearch-ci/packaging-sample |
jbaiera
pushed a commit
to jbaiera/elasticsearch
that referenced
this pull request
Jul 15, 2019
…3623) This improves the error message when encrypting of sensitive watcher data is configured, but no system file was specified in the keystore. This error message is displayed on startup. This also closes the input stream of the secure file properly. Closes elastic#43619
This was referenced Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error message when encrypting of sensitive watcher
data is configured, but no system file was specified in the keystore.
This error message is displayed on startup.
This also closes the input stream of the secure file properly.
Closes #43619
Message on start up is now
reviewers note: Intend this to put into master and 7.x branches. please veto as part of your review.