Ensure enrich policy is immutable #43604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures the policy cannot be overwritten. An error is thrown if the policy exists. All tests have been updated accordingly.
hub-cap
added
the
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features |
55 tasks
martijnvg
approved these changes
Jun 26, 2019
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Left one comment about testing. LGTM otherwise.
| .build(); | ||
| } | ||
|
|
||
| public void testImmutablePolicy() throws IOException { |
Member
There was a problem hiding this comment.
I think this test should be added to CommonEnrichRestTestCase instead of here?
The outcome should be the same whether security is enabled or not?
Contributor
Author
There was a problem hiding this comment.
lol i cant believe i put it there... blame my ailing mind.
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
hub-cap
added a commit
that referenced
this pull request
Jul 11, 2019
This commit ensures the policy cannot be overwritten. An error is thrown if the policy exists. All tests have been updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures the policy cannot be overwritten. An error is thrown
if the policy exists. All tests have been updated accordingly.