Validate read priv of enrich source indices #43595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds permissions validation on the indices provided in the enrich policy. These indices should be validated at store time so as not to have cryptic error messages in the event the user does not have permissions to access said indices.
hub-cap
added
the
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
55 tasks
martijnvg
approved these changes
Jun 25, 2019
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM. I left a note around the error message.
|
|
||
| import java.nio.file.Path; | ||
|
|
||
| public class LocalStateEnrich extends LocalStateCompositeXPackPlugin { |
Member
There was a problem hiding this comment.
lets hope this can be nuked soon (in master)
Contributor
Author
There was a problem hiding this comment.
ugh yea... sins of my past
| if (r.isCompleteMatch()) { | ||
| putPolicy(request, listener); | ||
| } else { | ||
| listener.onFailure(Exceptions.authorizationError("Could not store policy because an index specified {} did not" + |
Member
There was a problem hiding this comment.
Maybe: unable to store policy, because no indices match with the specified index patterns [{}]
I don't think we have to include the fact that the user has no privileges to read specific indices,
because the user is unable to verify the existence of indices matching with the specified patterns.
Contributor
Author
|
@elasticmachine update branch |
hub-cap
added a commit
that referenced
this pull request
Jul 10, 2019
This commit adds permissions validation on the indices provided in the enrich policy. These indices should be validated at store time so as not to have cryptic error messages in the event the user does not have permissions to access said indices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds permissions validation on the indices provided in the
enrich policy. These indices should be validated at store time so as not
to have cryptic error messages in the event the user does not have
permissions to access said indices.